Initial update conditions checking #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I agree. |
Siegrift
reviewed
Oct 25, 2023
aquarat
changed the title
|
I see that this PR is failing the tests. How come you were able to merge it? 👀 |
I realized these https://github.com/api3dao/airseeker-v2/blob/main/.github/workflows/main.yml#L54 is the cause. We have different strategy for running tests in airseeker then we have in Airnode (which is fine imo). |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is largely a copy of the update conditions check in Airseeker v1 (why change something that works well?). I had to add some extra code due to
"noUncheckedIndexedAccess": true,intsconfig.jsand our stringent eslint rules.An alternative to ethers' BigNumber is to use BigNumber.js, which can handle floating point big numbers - it works nicely in Airseeker Telemetry and it's easier to think about.
Closes #18