Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logger from commons #33

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Add logger from commons #33

merged 2 commits into from
Oct 25, 2023

Conversation

Siegrift
Copy link
Collaborator

Closes #8

Rationale

Adds the logger from @api3/commons.The logger accepts some configuration and I've opted in configuration from ENVs. Alternative would be to put the logger configuration to config.json, but it creates a wierd dependency of not being able to use logger until the config is loaded (similarly, if config fails to load you can't log it).

The implementation is very similar to pusher.

Copy link
Collaborator

@aquarat aquarat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice a neat, I didn't see any specific issues.
I found it odd that the imports in src/env/env.ts are separated by new lines, but that's super minor.

@Siegrift
Copy link
Collaborator Author

I found it odd that the imports in src/env/env.ts are separated by new lines, but that's super minor.

That is part of ESLint. It takes care of grouping imports and each group is separated by new line.

@Siegrift Siegrift merged commit f37893a into main Oct 25, 2023
3 checks passed
@Siegrift Siegrift deleted the add-logger branch October 25, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logger
2 participants