Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use block number from the RPC call #322

Merged
merged 2 commits into from
May 28, 2024
Merged

Use block number from the RPC call #322

merged 2 commits into from
May 28, 2024

Conversation

bdrhn9
Copy link
Contributor

@bdrhn9 bdrhn9 commented May 28, 2024

Closes #314

@bdrhn9 bdrhn9 marked this pull request as ready for review May 28, 2024 11:28
@bdrhn9 bdrhn9 requested a review from Siegrift May 28, 2024 11:29
@Siegrift Siegrift changed the base branch from main to bdrhn9/issue305 May 28, 2024 11:37
@Siegrift
Copy link
Collaborator

@bdrhn9 Next time base the PR on the other branch, e.g.

image

(That makes it a bit easier to review)

Copy link
Collaborator

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@bdrhn9 bdrhn9 merged commit 48dfeab into bdrhn9/issue305 May 28, 2024
4 checks passed
@bdrhn9 bdrhn9 deleted the bdrhn9/issue314 branch May 28, 2024 11:42
bdrhn9 added a commit that referenced this pull request May 28, 2024
* Fetch gas price using low-level RPC method

* Add test for handling internal RPC call failure

* Do not import entire gas-price module

* Use block number from the RPC call (#322)

* Use block number from the RPC call

* Add test for failed block number fetch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use smaller block number - from the contract and from the RPC
2 participants