Use logic from commons #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdrhn9
approved these changes
Apr 24, 2024
| signedDatas: Record<BeaconId, SignedData>; | ||
| signedApiUrls: Record<ChainId, Record<ProviderName, SignedApiUrl[]>>; | ||
| derivedSponsorWallets: Record<string /* dAPI name or data feed ID */, Hex /* Private key */>; | ||
| signedDatas: Record<Hex /* Beacon ID */, SignedData>; |
There was a problem hiding this comment.
Keccak256Hash for beacon Ids?
There was a problem hiding this comment.
TBH I am not a great fan of that type. It's quite verbose to read/type and I don't see the benefit compared to Hex. I'd just stick with Hex unless there is a better reason for swithcing.
Also, TS will treat the Hex and Keccak256Hash as the same - so in the future if these are mixed it may cause unnecessary confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #250
Rationale
While implementing the issue I realised there is some more code that should be reused from commons. Each commit focuses on a particular feature implemented in commons.