Fix gas fetching, improve tests #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
force-pushed
the
fix-gas-fetching
branch
2 times, most recently
from
79e8778
to
2c4ff6a
Compare
Siegrift
commented
Apr 1, 2024
Siegrift
force-pushed
the
fix-gas-fetching
branch
from
fb1caf6
to
ebb3db1
Compare
vponline
approved these changes
Apr 2, 2024
bdrhn9
approved these changes
Apr 2, 2024
Siegrift
force-pushed
the
fix-gas-scaling
branch
from
bf9ebf5
to
6b6fd6a
Compare
Siegrift
force-pushed
the
fix-gas-fetching
branch
from
ebb3db1
to
b312b1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #218
Rationale
Here we've decided to make the gas fetching part of the "main" (update feeds) loop. The problem is that the gas was fetched from the RPC only before an update transaction was submitted.
Now it's fetched during the processing of each batch.