Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update engines #204

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Update engines #204

merged 2 commits into from
Mar 14, 2024

Conversation

Siegrift
Copy link
Collaborator

The engines are too strict and they are annoying when building new Docker image (because Docker caches the pnpm version) and this can also issue a warning when the package is installed as NPM.

@Siegrift Siegrift requested a review from bdrhn9 March 12, 2024 09:03
@Siegrift Siegrift self-assigned this Mar 12, 2024
Copy link
Contributor

@bdrhn9 bdrhn9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I also failed while building docker image. I solved it by adding --no-cache option to docker build command. I'd add this option to script in package.json 😄

@Siegrift
Copy link
Collaborator Author

I solved it by adding --no-cache option to docker build command. I'd add this option to script in package.json 😄

Yeah, I also used that a few times, but didn't want to add it to the script, but it was't a strong opinion. It won't matter much now, but I'll add it.

Base automatically changed from update-dockerfile to main March 14, 2024 07:31
@Siegrift Siegrift merged commit 0bcb481 into main Mar 14, 2024
4 checks passed
@Siegrift Siegrift deleted the update-engines branch March 14, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants