Improve local test utils #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
changed the title
Siegrift
force-pushed
the
polygon-local-run
branch
from
33d840b
to
98610d2
Compare
Siegrift
changed the title
Siegrift
commented
Nov 22, 2023
| }; | ||
|
|
||
| newActiveDapisHtml += JSON.stringify(dapiInfo, null, 2) + '\n\n'; | ||
| } | ||
| document.getElementById('activeDapis').innerHTML = newActiveDapisHtml; | ||
| }, 1000); | ||
| }, 3000); |
There was a problem hiding this comment.
Increased to avoid spamming public RPC providers too much.
Siegrift
commented
Nov 22, 2023
| @@ -50,6 +50,36 @@ export const deriveRole = (adminRole: string, roleDescription: string) => { | |||
| ); | |||
| }; | |||
|
|
|||
| export const refundFunder = async (funderWallet: ethers.Wallet) => { | |||
There was a problem hiding this comment.
This is not called, but you can call it manually by editing the script (call this instead of deploying the contracts and funding the sponsor wallets).
Siegrift
commented
Nov 22, 2023
There was a problem hiding this comment.
I needed to add tx.wait() for each transaction (otherwise I got errors).
Siegrift
commented
Nov 22, 2023
| @@ -174,8 +220,8 @@ export const deploy = async (funderWallet: ethers.Wallet, provider: ethers.provi | |||
| // Register merkle tree hashes | |||
| const timestamp = Math.floor(Date.now() / 1000); | |||
| const apiTreeValues = [ | |||
| [pusher1Wallet.address, `${pusher1.signedApis[0].url}/default`], // NOTE: Pusher pushes to the "/" of the signed API, but we need to query it additional path. | |||
| [pusher2Wallet.address, `${pusher2.signedApis[0].url}/default`], // NOTE: Pusher pushes to the "/" of the signed API, but we need to query it additional path. | |||
| [pusher1Wallet.address, joinUrl(pusher1.signedApis[0].url, 'default')], // NOTE: Pusher pushes to the "/" of the signed API, but we need to query it additional path. | |||
There was a problem hiding this comment.
One of my deployments didn't work because of a double slash in the URL.
Siegrift
requested review from
aquarat and
metobom
and removed request for
metobom
Siegrift
changed the title
Siegrift
commented
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Minor improvements to the local test configuration to make it runnable on other chains. I used that to deploy the contracts on Polygon testnet and run the Pushers and Signed APIs locally.
These are the contracts:
I've used the same dAPIs that were used in the local test, but I've set them up with 1% deviation.