Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase OEV gateway memory #1928

Merged
merged 2 commits into from
Jan 1, 2024
Merged

Increase OEV gateway memory #1928

merged 2 commits into from
Jan 1, 2024

Conversation

Siegrift
Copy link
Contributor

@Siegrift Siegrift commented Dec 31, 2023

We've been discussing plans to increase the OEV gateway memory to reuse the OEV gateway implementation in https://github.com/api3dao/oev-auctioneer/issues/6. I've done some experiments and the cold start varies depending on the gateway memory. This is because the lambda gets CPU proportionally to the memory (and higher memory means higher CPU which decreases the work at cold start).

I am opening a PR which changes the GW memory to 2048 (not configurable).

@Siegrift Siegrift self-assigned this Dec 31, 2023
@bbenligiray bbenligiray self-requested a review January 1, 2024 08:33
Copy link
Member

@bbenligiray bbenligiray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of anything else to be done about this

@Siegrift Siegrift changed the title WIP: Increase OEV gateway memory Increase OEV gateway memory Jan 1, 2024
@Siegrift
Copy link
Contributor Author

Siegrift commented Jan 1, 2024

I was waiting for our discussion in Slack to end, which I think did and I think this is good to go.

@Siegrift Siegrift merged commit 9241656 into master Jan 1, 2024
25 checks passed
@Siegrift Siegrift deleted the increase-oev-gw-memory branch January 1, 2024 19:13
@dcroote dcroote added this to the 0.14.0 milestone Jan 2, 2024
Ashar2shahid pushed a commit that referenced this pull request Jan 18, 2024
* Increase OEV gateway memory

* Add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants