Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): check for AirnodeRrp deployment in localhost flow #1895

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

dcroote
Copy link
Contributor

@dcroote dcroote commented Oct 9, 2023

Very minor. Contributes to #1559.

The error without this check is either Error: ENOENT: no such file or directory... or Error: invalid contract address or ENS name (argument="addressOrName", value=undefined, code=INVALID_ARGUMENT, version=contracts/5.7.0) depending on whether the deployments/localhost.json file is present. Both of these don't make it clear that the deploy-rrp wasn't run.

@dcroote dcroote self-assigned this Oct 9, 2023
@dcroote dcroote requested a review from Siegrift October 9, 2023 07:07
Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@dcroote dcroote merged commit 7946227 into master Oct 10, 2023
25 checks passed
@dcroote dcroote deleted the dcroote/ex-rrp-check branch October 10, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants