fix: airnode-protocol README and scripts updates #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcroote
force-pushed
the
dcroote/protocol-readme
branch
from
64e9393
to
1405a92
Compare
dcroote
commented
Sep 20, 2023
bbenligiray
reviewed
Sep 20, 2023
| @@ -30,4 +30,4 @@ const networks = Object.entries(references.chainNames).reduce((acc, [chainId, na | |||
| }, {}); | |||
| references.networks = networks; | |||
|
|
|||
| fs.writeFileSync(path.join('deployments', 'references.json'), JSON.stringify(references, null, 2)); | |||
| fs.writeFileSync(path.join('deployments', 'references.json'), JSON.stringify(references, null, 2) + '\n'); | |||
bbenligiray
approved these changes
Sep 20, 2023
Ashar2shahid
pushed a commit
that referenced
this pull request
Jan 18, 2024
* api3dao/chains is the network name source of truth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With relatively fresh eyes I identified updates needed within the
airnode-protocolREADME and scripts.