-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy Protocol Contracts to new chains #1864
Conversation
@andreogle can you take a look at api3dao/chains#64 and publish the package once merged so I can then make this ready for review ? |
fyi, ChainAPI has received a request to support Polygon zkEVM (mainnet and testnet). Once this PR is merged, the above networks will also be added to ChainAPI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ashar2shahid - shouldn't the "Verify Protocol Deployments" CI workflow have run here given all of the new packages/airnode-protocol
paths?
@dcroote yes it should have executed for this PR, strange that it didn't trigger. I will look into it. update: @dcroote I pushed the following PR to address the CI issue: #1865 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one minor question: mantle deployments are deterministic but mantle-goerli-testnet aren't? (Here is the CI run for reference)
@dcroote mantle-testnet desterminstic deployments were failing because I suspect the factory isn't deployed there: https://explorer.testnet.mantle.xyz/address/0x4e59b44847b379578588920cA78FbF26c0B4956C/transactions#address-tabs . When hardhat attempts to deploy it, I kept getting this error:
I tried with minimal gas price but it kept failing |
Not sure what the issue is with the create2 deployer contract at 0x4e59b44847b379578588920ca78fbf26c0b4956c, but it's absence looks like the issue. Transient gas issues? Otherwise, while it's not ideal, this wouldn't be the first chain with nondeterministic deployments and we now have functionality where these addresses don't need to be manually specified in the config as of v0.12 so it's even less of an issue. |
Our current protocol is |
* deploy contracts to mantle * deploy contracts to linea * deploy contracts on base * deploy contracts to polygon-zkevm * deploy contracts to linea-testnet,base-testnet,mantle-testnet,polygon-zkevm-testnet * update @api3/chains version
The protocol contracts have been deployed and verified on block explorers to the following chains:
linea:
AccessControlRegistry
AirnodeRrpV0
AirnodeRrpV0DryRun
RequesterAuthorizerWithAirnode
linea-goerli-testnet:
AccessControlRegistry
AirnodeRrpV0
AirnodeRrpV0DryRun
RequesterAuthorizerWithAirnode
mantle:
AccessControlRegistry
AirnodeRrpV0
AirnodeRrpV0DryRun
RequesterAuthorizerWithAirnode
mantle-goerli-testnet:
AccessControlRegistry
AirnodeRrpV0
AirnodeRrpV0DryRun
RequesterAuthorizerWithAirnode
base:
AccessControlRegistry
AirnodeRrpV0
AirnodeRrpV0DryRun
RequesterAuthorizerWithAirnode
base-goerli-testnet:
AccessControlRegistry
AirnodeRrpV0
AirnodeRrpV0DryRun
RequesterAuthorizerWithAirnode
polygon-zkevm:
AccessControlRegistry
AirnodeRrpV0
AirnodeRrpV0DryRun
RequesterAuthorizerWithAirnode
polygon-zkevm-testnet(block explorer is currently broken):
AccessControlRegistry
AirnodeRrpV0
AirnodeRrpV0DryRun
RequesterAuthorizerWithAirnode
This cannot be merged until api3dao/chains#64 is merged