Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement gas price strategy sanitizedProviderRecommendedGasPrice #1828

Merged
merged 5 commits into from
Jul 12, 2023
Merged

Implement gas price strategy sanitizedProviderRecommendedGasPrice #1828

merged 5 commits into from
Jul 12, 2023

Conversation

bdrhn9
Copy link
Contributor

@bdrhn9 bdrhn9 commented Jul 9, 2023 •
edited
Loading

Closes #1711

@bdrhn9 bdrhn9 self-assigned this Jul 9, 2023
@bdrhn9 bdrhn9 mentioned this pull request Jul 9, 2023
Closed
@bdrhn9 bdrhn9 marked this pull request as ready for review July 9, 2023 22:35
@bdrhn9 bdrhn9 requested a review from dcroote July 10, 2023 00:09
dcroote
dcroote approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice implementation and tests. My only suggestion is adding sanitizedProviderRecommendedGasPrice to the E2E test suite here: packages/airnode-utilities/test/e2e/gas-oracle.feature.ts

@bdrhn9
Copy link
Contributor Author

bdrhn9 commented Jul 12, 2023

Nice implementation and tests. My only suggestion is adding sanitizedProviderRecommendedGasPrice to the E2E test suite here: packages/airnode-utilities/test/e2e/gas-oracle.feature.ts

Thanks for your review. I added some e2e tests. I think it is mergeable at that point isn't it?

@dcroote
Copy link
Contributor

dcroote commented Jul 12, 2023

I think it is mergeable at that point isn't it?

Agreed 👍

@bdrhn9 bdrhn9 merged commit 5845e77 into master Jul 12, 2023
@bdrhn9 bdrhn9 deleted the bdrhn9/issue1711 branch July 12, 2023 16:38
@metobom metobom mentioned this pull request Jul 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcroote dcroote dcroote approved these changes

Assignees

@bdrhn9 bdrhn9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the gas price strategy: Sanitized providerRecommendedGasPrice
2 participants
@bdrhn9 @dcroote