-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency prettier to v3 #1825
Conversation
c3ab007
to
4776e0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prettier.format()
returns Promise<string>
instead of string
now that it has been made async in v3, hence the broken build
Also the latest prettier-plugin-solidity version doesn't work with prettier 3.0.0 yet |
dbad665
to
d5fe208
Compare
55fba19
to
64a03f8
Compare
985f63c
to
6b78922
Compare
bd1140d
to
2741da7
Compare
2741da7
to
8a2da92
Compare
dd99915
to
f89aa4d
Compare
f89aa4d
to
276c72e
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
@@ -29,7 +29,7 @@ | |||
"run-airnode-locally": "ts-node src/scripts/run-airnode-locally.ts", | |||
"sponsor-requester": "ts-node src/scripts/sponsor-requester.ts", | |||
"stop-local-airnode": "ts-node src/scripts/stop-local-airnode.ts", | |||
"test": "jest --selectProjects unit", | |||
"test": "NODE_OPTIONS=--experimental-vm-modules jest --selectProjects unit", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is required because prettier v3 made the migration to using ECMAScript Modules, which jest
has only experimental support for. The fix is adapted from their option number 2.
An example of the error before adding this was:
@api3/airnode-examples: ● Verifies that all config.example.json files are up to date › checks /home/runner/work/airnode/airnode/packages/airnode-examples/integrations/coingecko-post-processing
@api3/airnode-examples: Error: You need to run with a version of node that supports ES Modules in the VM API. See https://jestjs.io/docs/ecmascript-modules
@api3/airnode-examples:
@api3/airnode-examples: at createGoError (../../node_modules/@api3/promise-utils/src/index.ts:59:15)
@api3/airnode-examples: at ../../node_modules/@api3/promise-utils/src/index.ts:134:12
@api3/airnode-examples: at Generator.throw (<anonymous>)
@api3/airnode-examples: at rejected (../../node_modules/@api3/promise-utils/build/cjs/index.js:6:65)
@andreogle would you mind reviewing? The CI is only failing because of the unrelated "Verify Protocol Deployments" check, which has been very flaky for the past several commits / PRs. |
* chore(deps): update dependency prettier to v3 * fix(deps): update prettier format to be async * fix(deps): apply prettier v3 formatting * fix(deps): prettier ECMAScript Modules jest fix --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Derek Croote <[email protected]>
This PR contains the following updates:
^2.8.8
->^3.0.3
Release Notes
prettier/prettier (prettier)
v3.0.3
Compare Source
diff
Add
preferUnplugged: true
topackage.json
(#15169 by @fisker and @so1ve)Prettier v3 uses dynamic imports, user will need to unplug Prettier when Yarn's PnP mode is enabled, add
preferUnplugged: true
topackage.json
, so Yarn will install Prettier as unplug by default.Support shared config that forbids
require()
(#15233 by @fisker)If an external shared config package is used, and the package
exports
don't haverequire
ordefault
export.In Prettier 3.0.2 Prettier fails when attempt to
require()
the package, and throws an error.Allow argument of
require()
to break (#15256 by @fisker)Do not print trailing commas in arrow function type parameter lists in
ts
code blocks (#15286 by @sosukesuzuki)Support TypeScript 5.2
using
/await using
declaration (#15321 by @sosukesuzuki)Support for the upcoming Explicit Resource Management feature in ECMAScript.
using
/await using
declarationv3.0.2
Compare Source
diff
Break after
=
of assignment if RHS is poorly breakable AwaitExpression or YieldExpression (#15204 by @seiyab)Do not add trailing comma for grouped scss comments (#15217 by @auvred)
Print
declare
andexport
keywords for nested namespace (#15249 by @sosukesuzuki)v3.0.1
Compare Source
diff
Fix cursor positioning for a special case (#14812 by @fisker)
Fix plugins/estree.d.ts to make it a module (#15018 by @kingyue737)
Add
export {}
inplugins/estree.d.ts
to fix the "File is not a module" errorAdd parenthesis around leading multiline comment in return statement (#15037 by @auvred)
Add support for Vue "Generic Components" (#15066 by @auvred)
https://blog.vuejs.org/posts/vue-3-3#generic-components
Fix comments print in
IfStatement
(#15076 by @fisker)Add missing type definition for
printer.preprocess
(#15123 by @so1ve)Add missing
getVisitorKeys
method type definition forPrinter
(#15125 by @auvred)Add typing to support
readonly
array properties of AST Node (#15127 by @auvred)Add space before unary minus followed by a function call (#15129 by @pamelalozano)
v3.0.0
Compare Source
diff
🔗 Release Notes
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.