Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency lerna to v7 #1802

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 8, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
lerna (source) ^6.6.2 -> ^7.0.2 age adoption passing confidence

Release Notes

lerna/lerna

v7.0.2

Compare Source

Note: Version bump only for package lerna

v7.0.1

Compare Source

Note: Version bump only for package lerna

v7.0.0

Compare Source

Bug Fixes
Features
  • add migration for adding $schema, increase some strictness (73ceac3)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team June 8, 2023 20:03
@renovate renovate bot force-pushed the renovate/major-lerna-monorepo branch 3 times, most recently from 78cc0d0 to 8bfb493 Compare June 14, 2023 01:46
@renovate renovate bot changed the title Update dependency lerna to v7 chore(deps): update dependency lerna to v7 Jun 15, 2023
@renovate renovate bot force-pushed the renovate/major-lerna-monorepo branch 2 times, most recently from ff0ea6b to c343593 Compare June 15, 2023 13:25
@renovate renovate bot force-pushed the renovate/major-lerna-monorepo branch from c343593 to 1ee10bf Compare June 16, 2023 14:03
Copy link
Contributor

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are affected by the breaking changes in lerna v7. For example, lerna bootstrap has been removed and our use of it is causing the build to fail:

"bootstrap": "yarn install && lerna bootstrap",

There is a docs page on the rationale and migration: https://lerna.js.org/docs/legacy-package-management

@renovate renovate bot requested a review from a team June 20, 2023 08:12
@dcroote dcroote self-assigned this Jun 26, 2023
@renovate
Copy link
Contributor Author

renovate bot commented Jun 26, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@dcroote
Copy link
Contributor

dcroote commented Jun 26, 2023

@amarthadan and/or @andreogle - the upgrade to lerna v7 wasn't too difficult, but wanted a second pair of eyes before merging. See my comment above for how it affected us and a link to the migration guide.

Copy link
Contributor

@amarthadan amarthadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (installs and builds on my machine). Not sure whether this affects package building but I guess we'll see when we get there 😄 The question is whether we still actually need lerna. What are its benefits at this point?

@dcroote
Copy link
Contributor

dcroote commented Jun 26, 2023

We use it in several package.json commands and my understanding is we benefit from parallel, efficient execution and caching.

For building:

"build": "lerna run build --stream && ts-node scripts/make-cli-executable.ts",

For testing:

"test": "lerna run test --stream",

And for doing things with single packages:

"cli:deployer": "lerna run --scope @api3/airnode-deployer cli -- --",

@amarthadan
Copy link
Contributor

Not really sure we benefit from the caching that much. But the parallel execution is nice. That can't be done with yarn v1 workspaces. It is supported in v2 though. Maybe sometime down the line when we migrate to a different (newer) package manager we would be able to get rid of lerna.

@dcroote
Copy link
Contributor

dcroote commented Jun 27, 2023

That sounds like a plan to me

@dcroote dcroote merged commit 2eb178f into master Jun 27, 2023
@dcroote dcroote deleted the renovate/major-lerna-monorepo branch June 27, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants