-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency lerna to v7 #1802
Conversation
78cc0d0
to
8bfb493
Compare
ff0ea6b
to
c343593
Compare
c343593
to
1ee10bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are affected by the breaking changes in lerna v7. For example, lerna bootstrap
has been removed and our use of it is causing the build to fail:
Line 19 in 2107659
"bootstrap": "yarn install && lerna bootstrap", |
There is a docs page on the rationale and migration: https://lerna.js.org/docs/legacy-package-management
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
@amarthadan and/or @andreogle - the upgrade to lerna v7 wasn't too difficult, but wanted a second pair of eyes before merging. See my comment above for how it affected us and a link to the migration guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (installs and builds on my machine). Not sure whether this affects package building but I guess we'll see when we get there 😄 The question is whether we still actually need lerna. What are its benefits at this point?
We use it in several For building: Line 20 in 2107659
For testing: Line 83 in 2107659
And for doing things with single packages: Line 35 in 2107659
|
Not really sure we benefit from the caching that much. But the parallel execution is nice. That can't be done with yarn v1 workspaces. It is supported in v2 though. Maybe sometime down the line when we migrate to a different (newer) package manager we would be able to get rid of lerna. |
That sounds like a plan to me |
This PR contains the following updates:
^6.6.2
->^7.0.2
Release Notes
lerna/lerna
v7.0.2
Compare Source
Note: Version bump only for package lerna
v7.0.1
Compare Source
Note: Version bump only for package lerna
v7.0.0
Compare Source
Bug Fixes
Features
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.