Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of commands in packaging script #1726

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Fix order of commands in packaging script #1726

merged 1 commit into from
Apr 19, 2023

Conversation

amarthadan
Copy link
Contributor

The problem was that the dependencies were installed before switching the branch causing potential incompatibility.

I'll merge this once 0.11.0 is released (so I don't need to recreate #1720) but I will build the releasing container with the fix in place.

@amarthadan amarthadan requested a review from a team April 10, 2023 06:48
@amarthadan amarthadan self-assigned this Apr 10, 2023
Copy link
Contributor

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@amarthadan amarthadan merged commit a16d0cc into master Apr 19, 2023
@amarthadan amarthadan deleted the fix-packaging branch April 19, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants