Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Estimate gas for RRP fulfillments" #1710

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Revert "Estimate gas for RRP fulfillments" #1710

merged 2 commits into from
Apr 4, 2023

Conversation

Siegrift
Copy link
Contributor

@Siegrift Siegrift commented Apr 4, 2023 •
edited
Loading

@Siegrift Siegrift requested a review from bdrhn9 April 4, 2023 10:44
@Siegrift Siegrift self-assigned this Apr 4, 2023
@Siegrift Siegrift requested a review from amarthadan April 4, 2023 10:44
@Siegrift Siegrift marked this pull request as ready for review April 4, 2023 10:46
bdrhn9
bdrhn9 approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@bdrhn9 bdrhn9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Siegrift
Copy link
Contributor Author

Siegrift commented Apr 4, 2023

Github is able to create a revert PR. Since there were only tiny updates added after this PR this should be a clean revert.

@Siegrift Siegrift merged commit e8cc9ed into master Apr 4, 2023
@Siegrift Siegrift deleted the revert-1693-estimate-gas-for-fulfillments branch April 4, 2023 11:37
bdrhn9 added a commit that referenced this pull request Apr 17, 2023
@bdrhn9
Revert "Revert "Estimate gas for RRP fulfillments" (#1710)"
fb2e508 
This reverts commit e8cc9ed.
bdrhn9 added a commit that referenced this pull request Jun 26, 2023
@bdrhn9
Revert "Revert "Estimate gas for RRP fulfillments" (#1710)"
cdcbbae 
This reverts commit e8cc9ed.
@bdrhn9 bdrhn9 mentioned this pull request Jun 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdrhn9 bdrhn9 bdrhn9 approved these changes

@amarthadan amarthadan Awaiting requested review from amarthadan

Assignees

@Siegrift Siegrift

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Siegrift @bdrhn9