Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: script to bump OIS version references #1686

Merged
merged 5 commits into from
Mar 28, 2023
Merged

Conversation

dcroote
Copy link
Contributor

@dcroote dcroote commented Mar 21, 2023

Closes #1441. Using the script I found a config file that was quite outdated and updated it. I tested this by running the script with an arbitrary version different than the current version (2.0.0) and confirming that all files that include oisFormat were modified.

@dcroote dcroote self-assigned this Mar 21, 2023
@dcroote dcroote requested a review from a team March 21, 2023 06:16
scripts/update-ois-version.ts Outdated Show resolved Hide resolved
scripts/update-ois-version.ts Show resolved Hide resolved
@dcroote
Copy link
Contributor Author

dcroote commented Mar 24, 2023

Failing codeql CI appears unrelated as it is suddenly also affecting this aws dependency update.

@dcroote
Copy link
Contributor Author

dcroote commented Mar 24, 2023

Tests back to passing

Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@dcroote dcroote merged commit 62f105f into master Mar 28, 2023
@dcroote dcroote deleted the dcroote/issue1441 branch March 28, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump OIS version references every time OIS package is updated
3 participants