Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Airnode to use Node 18 #1647

Merged
merged 4 commits into from
Feb 14, 2023
Merged

Update Airnode to use Node 18 #1647

merged 4 commits into from
Feb 14, 2023

Conversation

dcroote
Copy link
Contributor

@dcroote dcroote commented Feb 10, 2023 •
edited
Loading

Closes #1631 and closes #1346. While this doesn't address #1544, that can be done after (given it requires another OIS release) as the engine specification doesn't actually appear to enforce version 14 of Node 14.

Edit: The airnode-node unit tests all pass, yet the step fails... Trying to isolate / reproduce. Found the failing test and fixed it.

@dcroote dcroote requested a review from a team February 11, 2023 06:26
@dcroote dcroote self-assigned this Feb 11, 2023
@dcroote dcroote mentioned this pull request Feb 11, 2023
Closed
amarthadan
amarthadan previously approved these changes Feb 13, 2023
View reviewed changes
@amarthadan
Copy link
Contributor

I've approved this prematurely 😄 I've just realized that you're missing one crucial thing. You need to update the Node.js environment for serverless functions to Node 18 as well. Here and here.

@amarthadan amarthadan dismissed their stale review February 13, 2023 07:57

I've missed one crucial thing, detals in the comment.

amarthadan
amarthadan approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@amarthadan amarthadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think that's all now 🤞 😄

@dcroote
Copy link
Contributor Author

dcroote commented Feb 14, 2023

Thanks @amarthadan and nice catch on the terraform functions.

I tested the airnode container, AWS deployment, and GCP deployment each with a blockchain and HTTP gateway request.

@dcroote dcroote merged commit a4929ee into master Feb 14, 2023
@dcroote dcroote deleted the dcroote/issue1631 branch February 14, 2023 08:19
This was referenced Feb 14, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarthadan amarthadan amarthadan approved these changes

Assignees

@dcroote dcroote

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Airnode to use Node 18 Update hardhat to ^2.10.0
2 participants
@dcroote @amarthadan