Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.10.0 #1640

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Release v0.10.0 #1640

merged 1 commit into from
Feb 7, 2023

Conversation

amarthadan
Copy link
Contributor

No description provided.

@amarthadan amarthadan requested a review from a team February 6, 2023 16:06
Copy link
Contributor

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so that I don't delay merging, but I think the failing unit tests should be fixed first. The failures originate from the derivation of deploymentId, which takes the airnodeVersion as a parameter and is therefore different now than for v0.9.

export function deriveDeploymentId(
cloudProvider: LocalOrCloudProvider,
airnodeAddress: string,
stage: string,
airnodeVersion: string
) {
return `${cloudProvider.type}${crypto
.createHash('sha256')
.update([...cloudProviderHashElements(cloudProvider), airnodeAddress, stage, airnodeVersion].join(''))
.digest('hex')
.substring(0, DEPLOYMENT_ID_LENGTH)}`;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants