-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add handling of _minConfirmations reserved parameter #1615
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcroote
commented
Jan 20, 2023
compact will filter out minConfirmations of 0 so can't use
amarthadan
approved these changes
Feb 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, mostly nits. But please try reworking the tests so you don't need to change the startCoordinator
interface.
I'm approving to move it along but I will test it later as well.
I tested the new feature and it looks like it's working correctly, nicely done 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1393
0
if_minConfirmations
reserved parameter set (see comment below)_minConfirmations
from request_minConfirmations
larger thanBLOCK_COUNT_HISTORY_LIMIT
chains[n].minConfirmations
or, if allowed and present,_minConfirmations
request parameter_minConfirmations
passed as a request parameter if_minConfirmations
reserved parameter is not present for an endpoint_minConfirmations
-requests are filtered according to the reserved parameter in the specific request, then those remaining are assigned nonces as before.Per the original spec, the max_minConfirmations
for each sponsor is applied to all requests in the queue