New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fetch-files command to deployer #1603

Merged

amarthadan merged 1 commit into master from deployer-fetch-files

Jan 10, 2023

Contributor

amarthadan commented Jan 8, 2023

Close #1405

amarthadan requested a review from a team

January 8, 2023 22:07

amarthadan self-assigned this

amarthadan force-pushed the deployer-fetch-files branch from 68611ac to d4760e1 Compare

January 9, 2023 07:05

Siegrift reviewed

View reviewed changes

packages/airnode-deployer/src/cli/index.ts Show resolved Hide resolved

Siegrift reviewed

View reviewed changes

packages/airnode-deployer/src/infrastructure/index.test.ts

+                  name: 'airnode-123456789',
+                  region: 'us-east-1',
+                };
+                const configPath = path.join(__dirname, '..', '..', 'test', 'fixtures', 'config.aws.valid.json');

Contributor

Siegrift Jan 9, 2023

Nit: You can just do path.join(__dirname, '../../test/fixtures/config.aws.valid.json')

Siegrift reviewed

View reviewed changes

packages/airnode-deployer/src/infrastructure/index.test.ts Show resolved Hide resolved

Siegrift reviewed

View reviewed changes

packages/airnode-deployer/src/infrastructure/index.test.ts Show resolved Hide resolved

Siegrift reviewed

View reviewed changes

packages/airnode-deployer/src/infrastructure/index.test.ts Outdated Show resolved Hide resolved

Siegrift reviewed

View reviewed changes

packages/airnode-deployer/src/infrastructure/index.ts Show resolved Hide resolved

Siegrift approved these changes

View reviewed changes

Contributor

Siegrift left a comment •

edited

Loading

👍 LGTM


          Add fetch-files command to deployer

a29bed4

amarthadan force-pushed the deployer-fetch-files branch from d4760e1 to a29bed4 Compare

January 9, 2023 14:53

amarthadan merged commit e744b4e into master

amarthadan deleted the deployer-fetch-files branch

January 10, 2023 08:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet