Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --cache property to prettier and eslint #1600

Merged
merged 3 commits into from
Jan 7, 2023
Merged

Add --cache property to prettier and eslint #1600

merged 3 commits into from
Jan 7, 2023

Conversation

dcroote
Copy link
Contributor

@dcroote dcroote commented Jan 5, 2023

Closes #1595

@dcroote dcroote self-assigned this Jan 5, 2023
@dcroote dcroote requested a review from Siegrift January 5, 2023 06:31
@Siegrift
Copy link
Contributor

Siegrift commented Jan 6, 2023

Btw. eslint also supports --cache so we might as well add it there (do not forget to add .eslintcache to gitignore)

Siegrift
Siegrift approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, but add it for ESlint as well.

@dcroote
Copy link
Contributor Author

dcroote commented Jan 7, 2023

Btw. eslint also supports --cache so we might as well add it there (do not forget to add .eslintcache to gitignore)

Good call- yarn lint:eslint went from 17s down to 1.5s

@dcroote dcroote changed the title Add --cache property to prettier Add --cache property to prettier and eslint Jan 7, 2023
@dcroote dcroote merged commit 7e66b92 into master Jan 7, 2023
@dcroote dcroote deleted the dcroote/prettier-cache branch January 7, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siegrift Siegrift Siegrift approved these changes

Assignees

@dcroote dcroote

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "--cache" option to prettier
2 participants
@dcroote @Siegrift