Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing GH token env variable #1593

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Add missing GH token env variable #1593

merged 1 commit into from
Dec 9, 2022

Conversation

amarthadan
Copy link
Contributor

When doing the v0.9.2 release I run into an issue that I forgot to pass the GitHub token environment variable to the Docker command running the build process.

The GitHub token is there to tag the commit after the publishing and push that tag to GitHub.

@amarthadan amarthadan requested a review from a team December 9, 2022 07:53
@amarthadan amarthadan self-assigned this Dec 9, 2022
Copy link
Contributor

@aquarat aquarat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌
Pretty cool that this is in production now 🚀 😇

@amarthadan amarthadan merged commit 3fcbc37 into master Dec 9, 2022
@amarthadan amarthadan deleted the fix-release-scripts branch December 9, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants