Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin axios after v1.2.2 patch release #1591

Merged
merged 3 commits into from
Jan 2, 2023
Merged

Unpin axios after v1.2.2 patch release #1591

merged 3 commits into from
Jan 2, 2023

Conversation

dcroote
Copy link
Contributor

@dcroote dcroote commented Dec 8, 2022

Reverts #1553 now that the patch release for the broken v1.2.0 is out

@dcroote
Copy link
Contributor Author

dcroote commented Dec 8, 2022

v1.2.1 is also broken, see axios/axios#5346, which matches our below E2E test error:

[2022-12-08 05:59:02.037] ERROR Error: unexpected end of file
    at Function.AxiosError.from (/usr/local/share/.config/yarn/global/node_modules/axios/dist/node/axios.cjs:785:14)
    at BrotliDecompress.handleStreamError (/usr/local/share/.config/yarn/global/node_modules/axios/dist/node/axios.cjs:2696:29)
    at BrotliDecompress.emit (events.js:412:35)
    at BrotliDecompress.emit (domain.js:475:12)
    at emitErrorNT (internal/streams/destroy.js:106:8)
    at emitErrorCloseNT (internal/streams/destroy.js:74:3)
    at processTicksAndRejections (internal/process/task_queues.js:82:21) Coordinator-ID:3bfe8fa2ae376c65, Chain-ID:31337, Provider:exampleProvider, Endpoint-ID:0xfb87102cdabadf905321521ba0b3cbf74ad09c5d400ac2eccdbef8d6143e78c4

Marking as draft until the next release

@dcroote dcroote marked this pull request as draft December 8, 2022 06:03
@dcroote dcroote self-assigned this Dec 8, 2022
@dcroote dcroote changed the title Unpin axios after v1.2.1 patch release Unpin axios after v1.2.2 patch release Dec 29, 2022
@dcroote dcroote marked this pull request as ready for review December 29, 2022 19:51
@dcroote
Copy link
Contributor Author

dcroote commented Dec 29, 2022

The 1.2.2 release works so this is ready for review & merge

@dcroote dcroote requested a review from a team December 29, 2022 20:21
Siegrift
Siegrift reviewed Dec 31, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
Siegrift
Siegrift reviewed Dec 31, 2022
View reviewed changes
Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is yarn.lock not changed?

@dcroote
Copy link
Contributor Author

dcroote commented Dec 31, 2022

Why is yarn.lock not changed?

My intention was to only revert #1553 and let Renovate take care of the update, but I went ahead and bumped it in the latest commit 👍

Siegrift
Siegrift approved these changes Jan 2, 2023
View reviewed changes
Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My intention was to only revert #1553 and let Renovate take care of the update, but I went ahead and bumped it in the latest commit 👍

I was just surprised, but it's better to update this to a working version explicitly.

👍 LGTM

@dcroote dcroote merged commit 94b072b into master Jan 2, 2023
@dcroote dcroote deleted the unpin-axios branch January 2, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siegrift Siegrift Siegrift approved these changes

Assignees

@dcroote dcroote

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcroote @Siegrift