Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip api call #1586

Merged
merged 11 commits into from
Dec 8, 2022
Merged

Skip api call #1586

merged 11 commits into from
Dec 8, 2022

Conversation

metobom
Copy link
Member

@metobom metobom commented Dec 2, 2022 •
edited
Loading

Added a feature that lets skipping API calls. Instead of API call it uses output of preProcessingSpecifications, postProcessingSpecifications, or both. To skip API call, operation must be undefined, fixedOperationParameters must be an empty array and one of preProcessingSpecifications or postProcessingSpecifications must be defined and not be an empty array.

Closes #1527

andreogle
andreogle requested changes Dec 3, 2022
View reviewed changes
packages/airnode-node/src/api/index.ts Outdated Show resolved Hide resolved
packages/airnode-node/src/api/index.ts Outdated Show resolved Hide resolved
packages/airnode-node/src/api/index.ts Outdated Show resolved Hide resolved
packages/airnode-node/src/api/index.ts Outdated Show resolved Hide resolved
packages/airnode-node/src/types.ts Outdated Show resolved Hide resolved
packages/airnode-node/src/api/index.test.ts Outdated Show resolved Hide resolved
packages/airnode-node/src/api/index.ts Show resolved Hide resolved
packages/airnode-node/src/api/index.test.ts Outdated Show resolved Hide resolved
packages/airnode-node/src/api/index.test.ts Outdated Show resolved Hide resolved
andreogle
andreogle approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@andreogle andreogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👌🏻 Nothing more from my end

amarthadan
amarthadan approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@amarthadan amarthadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@metobom metobom merged commit 47a026f into master Dec 8, 2022
@metobom metobom deleted the skip-api-call branch December 8, 2022 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreogle andreogle andreogle approved these changes

@amarthadan amarthadan amarthadan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow API call to be skipped in endpoints
3 participants
@metobom @amarthadan @andreogle