Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failed lambda execution crashing coordinator #1582

Merged
merged 3 commits into from
Dec 5, 2022
Merged

Fix failed lambda execution crashing coordinator #1582

merged 3 commits into from
Dec 5, 2022

Conversation

Siegrift
Copy link
Contributor

@Siegrift Siegrift commented Dec 1, 2022 •
edited
Loading

Closes #1581

I wanted to write a test for this, but this is reproducible only on AWS...

@Siegrift Siegrift requested review from amarthadan and a team December 1, 2022 18:08
@Siegrift Siegrift self-assigned this Dec 1, 2022
@Siegrift Siegrift changed the title Proper lambda error handling master Fix failed lambda execution crashing coordinator Dec 1, 2022
@Siegrift Siegrift mentioned this pull request Dec 1, 2022
Closed
amarthadan
amarthadan approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@amarthadan amarthadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, otherwise LGTM 👍

packages/airnode-node/src/workers/cloud-platforms/aws.ts Outdated Show resolved Hide resolved
@Siegrift Siegrift merged commit 34f9425 into master Dec 5, 2022
@Siegrift Siegrift deleted the proper-lambda-error-handling-master branch December 5, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarthadan amarthadan amarthadan approved these changes

Assignees

@Siegrift Siegrift

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate coordinator failure for faulty provider
2 participants
@Siegrift @amarthadan