fix: undefined error property in json logging

[dcroote]

Closes #1547. Relatively simple fix as the bug appears to just have been a typo of copying the wrong line i.e. the code block several lines above this change has the correct conditional.

[amarthadan]

It does fix the unhandled error but since the error occurred, it means that the logFull function was at some point called with level set to ERROR and options.error being null. This way we will just ignore that call, won't we?

[dcroote]

It does fix the unhandled error but since the error occurred, it means that the logFull function was at some point called with level set to ERROR and options.error being null. This way we will just ignore that call, won't we?

There are some instances where we do log errors without an error, for example:

airnode/packages/airnode-node/src/coordinator/calls/coordinated-execution.ts

Line 46 in 74f33ea

const log = logger.pend('ERROR', `${baseLogMsg} failed after ${durationMs}ms`);

But that is somewhat beside the point here as the changed code block corresponds to providing an additional log when there is a stack available. If you look one line above the changed line, the error will still be logged in the case where there isn't an error:

airnode/packages/airnode-utilities/src/logging/logging.ts

Lines 119 to 121 in 3034ad0

	json(level, message, options);
	if (level === 'ERROR' && (options as ErrorLogOptions).error?.stack) {
	json('ERROR', (options as ErrorLogOptions).error!.stack!, options);

[amarthadan]

Oh, right, must have missed that, sorry. Carry on 🙂