Fix Terraform boolean interpretation #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
approved these changes
Nov 17, 2022
| @@ -71,8 +71,8 @@ module "startCoordinator" { | |||
| airnode_bucket = var.airnode_bucket | |||
| deployment_bucket_dir = var.deployment_bucket_dir | |||
| environment_variables = { | |||
| HTTP_GATEWAY_URL = var.http_gateway_enabled == false ? null : "https://${module.httpGw[0].api_url}/${random_uuid.http_path_key.result}" | |||
| HTTP_SIGNED_DATA_GATEWAY_URL = var.http_signed_data_gateway_enabled == false ? null : "https://${module.httpSignedGw[0].api_url}${random_uuid.http_signed_data_path_key.result}" | |||
| HTTP_GATEWAY_URL = var.http_gateway_enabled ? "https://${module.httpGw[0].api_url}/${random_uuid.http_path_key.result}" : null | |||
There was a problem hiding this comment.
I am wondering why it was working back in https://github.com/api3dao/airnode/pull/1418/files#diff-296ebb005304c61b91c2f50aa9a9c697158399ee17503b6a7a6374ebab553a4aR40 (I've also checked by deploying using docker image from that commit).
There was a problem hiding this comment.
Not sure tbh 🤷♂️
amarthadan
force-pushed
the
terraform-bool-fix
branch
from
7a5e40d
to
80bf617
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1530
It looks like Terraform doesn't like boolean comparisons (
bool_var == falsevs!bool_var) and may also interpret variables from the command line as strings without type being specified. I did change both and it looks like it works correctly now.Tested only AWS, leaving GCP to @martinkolenic.