Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Terraform recepts for AWS after bad rebase #1531

Merged
merged 3 commits into from
Nov 15, 2022
Merged

Conversation

Siegrift
Copy link
Contributor

@Siegrift Siegrift commented Nov 14, 2022

Closes #1530

I've reproduced the issue on master and looked at the broken changes. This should fix the issue... The reason I missed this was because the code for the TF receipts was only added and there were no conflicts per se… The merged code was just not compatible anymore…

  • Wait until CI passes and builds the docker and test by deploying on AWS and making signed data gateway request

@Siegrift Siegrift self-assigned this Nov 14, 2022
@Siegrift Siegrift marked this pull request as ready for review November 14, 2022 13:12
@Siegrift Siegrift requested a review from a team November 14, 2022 15:39
Copy link
Contributor

@amarthadan amarthadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (but I haven't tested it, I presume you did)

Btw, it's recipe and plural recipes 😄 👨‍🍳

@Siegrift Siegrift merged commit 7f9ada0 into master Nov 15, 2022
@Siegrift Siegrift deleted the fix-tf-aws-receipts branch November 15, 2022 07:31
@@ -43,7 +43,7 @@ Before making the request, you need to replace the following placeholders:
The correct command may look like this:

```sh
curl -X POST -H 'Content-Type: application/json' -d '{"encodedParameters": "0x3173000000000000000000000000000000000000000000000000000000000000636f696e49640000000000000000000000000000000000000000000000000000626974636f696e00000000000000000000000000000000000000000000000000"}' 'https://am6ncplkx4.execute-api.us-east-1.amazonaws.com/v1/0xfb87102cdabadf905321521ba0b3cbf74ad09c5d400ac2eccdbef8d6143e78c4'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the coingecko-testable integration needs this too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployer broken after v0.10.0 merge fix attempt
3 participants