Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ropsten/rinkeby references #1476

Merged
merged 3 commits into from
Sep 28, 2022
Merged

Remove ropsten/rinkeby references #1476

merged 3 commits into from
Sep 28, 2022

Conversation

Siegrift
Copy link
Contributor

Closes #1280

@Siegrift Siegrift requested a review from a team September 27, 2022 06:48
@Siegrift Siegrift self-assigned this Sep 27, 2022
case 'goerli':
case 'kovan':
return getExamplePocketNetwork(values.network);
case 'polygon-mumbai':
case 'polygon-testnet':
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a bug before.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Base automatically changed from emo-deploy-sepolia to deploy-sepolia September 27, 2022 07:41
Base automatically changed from deploy-sepolia to master September 27, 2022 08:07
@Siegrift
Copy link
Contributor Author

I've tested using the docker container version airnode-examples. Works fine.

Copy link
Contributor

@aquarat aquarat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥 🚒

@aquarat aquarat modified the milestone: 0.9.0 Sep 28, 2022
@Siegrift Siegrift merged commit aa77354 into master Sep 28, 2022
@Siegrift Siegrift deleted the rem-rinkeby-ropsten branch September 28, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove remnants of Rinkeby and Ropsten networks
3 participants