Deploy on Sepolia #1463
Merged
Deploy on Sepolia #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
approved these changes
Sep 22, 2022
There was a problem hiding this comment.
👍 LGTM.
Looked at the verified contracts on Sepolia etherscan and it LGTM. I plan to test the RRP request when implementing #1280 as the ultimate test...
Btw. do we need this document? https://api3dao.atlassian.net/wiki/spaces/AIRNODE/pages/154697729/Airnode+protocol+deployment+process (There was a task for this some time ago, but I am not sure we need it).
|
@Siegrift Let me review that document before merging this. Btw, did you read the second part of the PR post? |
Which second part do you mean? |
|
|
Yeah, there is #1464 |
|
Thanks, will check it out |
Fix TS errors in generate-references script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't deploy deterministically because hardhat-deploy doesn't seem to support Sepolia yet (unlike xdeployer). I may redeploy once that becomes available (but maybe not?). I verified the contracts on Etherscan.
Btw, TS complains about the types in this bit. What do?