Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add corsOrigins option #1357

Merged
merged 8 commits into from
Aug 4, 2022
Merged

Add corsOrigins option #1357

merged 8 commits into from
Aug 4, 2022

Conversation

vponline
Copy link
Contributor

@vponline vponline commented Aug 2, 2022

Closes #1200

@vponline vponline self-assigned this Aug 2, 2022
@vponline vponline requested a review from a team August 2, 2022 06:23
@vponline vponline requested a review from Siegrift August 4, 2022 07:15
Siegrift
Siegrift approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM (but haven't deployed/tested on AWS).

After you merge I'll update the local gateways PR to support CORS as well.

packages/airnode-deployer/src/handlers/aws/index.ts Outdated Show resolved Hide resolved
@vponline vponline merged commit 9600ed3 into master Aug 4, 2022
@vponline vponline deleted the cors-config branch August 4, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siegrift Siegrift Siegrift approved these changes

Assignees

@vponline vponline

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Research (and implement if possible) enabling CORS on the HTTP gateways
2 participants
@vponline @Siegrift