Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.6] Fix cloud resource naming #1129

Merged
merged 4 commits into from
May 27, 2022
Merged

[0.6] Fix cloud resource naming #1129

merged 4 commits into from
May 27, 2022

Conversation

amarthadan
Copy link
Contributor

@amarthadan amarthadan commented May 26, 2022 •
edited
Loading

Backport to 0.6 from #1099

I had to add a fix from #1128 as well so our Docker containers get built.

@amarthadan amarthadan requested a review from a team May 26, 2022 12:37
@amarthadan amarthadan self-assigned this May 26, 2022
@amarthadan amarthadan requested a review from aquarat May 26, 2022 16:47
Siegrift
Siegrift approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@amarthadan amarthadan merged commit b7b09a9 into v0.6 May 27, 2022
@amarthadan amarthadan deleted the 0.6-fix-resource-naming branch May 27, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siegrift Siegrift Siegrift approved these changes

@aquarat aquarat Awaiting requested review from aquarat

Assignees

@amarthadan amarthadan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amarthadan @Siegrift