Convert gasPriceMultiplier to BigNumber #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
reviewed
May 5, 2022
| @@ -15,7 +15,7 @@ export const parsePriorityFee = ({ value, unit }: PriorityFee) => | |||
| ethers.utils.parseUnits(value.toString(), unit ?? 'wei'); | |||
|
|
|||
| export const multiplyGasPrice = (gasPrice: BigNumber, gasPriceMultiplier: number) => | |||
| gasPrice.mul(Math.round(gasPriceMultiplier * 100)).div(BigNumber.from(100)); | |||
| gasPrice.mul(BigNumber.from(Math.round(gasPriceMultiplier * 100))).div(BigNumber.from(100)); | |||
There was a problem hiding this comment.
Why is this needed? Afaik BigNumber accepts regular numbers as well.
There was a problem hiding this comment.
This is mostly for consistency (pointed out in #1043) as all the other numbers are converted to BigNumber in gas-prices (and mostly elsewhere in Airnode I believe).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix to change
gasPriceMultiplierinto a BigNumber before using in calculations.