Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve validator bundling #1051

Merged
merged 4 commits into from
May 5, 2022
Merged

Improve validator bundling #1051

merged 4 commits into from
May 5, 2022

Conversation

Siegrift
Copy link
Contributor

@Siegrift Siegrift commented Apr 30, 2022

https://api3dao.atlassian.net/browse/AN-622

Added build targets for non cjs targets. This makes it more optimal to load the validator inside the browser environment (although modern bundles would probably handle cjs as well).

I've tested this using a simple FE application and validator published locally (using verdaccio). I've also made sure the source maps works.

@Siegrift Siegrift requested review from amarthadan and a team April 30, 2022 11:15
@Siegrift Siegrift self-assigned this Apr 30, 2022
Copy link
Contributor

@amarthadan amarthadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure, we'll be still able to use

import { parseConfigWithSecrets } from '@api3/airnode-validator';

and not something like

import { parseConfigWithSecrets } from '@api3/airnode-validator/dist/cjs/...';

@Siegrift
Copy link
Contributor Author

Siegrift commented May 2, 2022

Yes. We will for all things that are exported in via the main index.js file

Base automatically changed from improve-readme to master May 4, 2022 09:51
@Siegrift Siegrift merged commit d839957 into master May 5, 2022
@Siegrift Siegrift deleted the validator-bundle branch May 5, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants