Fix condition for enabling GCP API gateway service #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarthadan
commented
Apr 27, 2022
| "docker": "yarn docker:build:artifacts && yarn docker:build:deployer && yarn docker:build:client && yarn docker:build:admin", | ||
| "docker:build": "yarn docker:build:artifacts && yarn docker:build:deployer && yarn docker:build:client && yarn docker:build:admin", |
There was a problem hiding this comment.
Not sure why we call it just docker and all the "subtasks" are called docker:build:* so I changed it.
amarthadan
force-pushed
the
fix-gcp-gateway-required-services
branch
from
dd34f2f
to
61043dc
Compare
Siegrift
approved these changes
Apr 27, 2022
| @@ -71,7 +71,7 @@ module "startCoordinator" { | |||
| } | |||
|
|
|||
| resource "google_project_service" "apigateway_api" { | |||
| count = var.http_api_key == null || var.http_signed_data_api_key == null ? 0 : 1 | |||
| count = var.http_api_key == null && var.http_signed_data_api_key == null ? 0 : 1 | |||
This was referenced Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug explains why all of a sudden we needed to enable the API gateway service manually on GCP.
Related to AN-698 and AN-700. Not sure it's the only issue though.