Clarify airnode-examples README for users and devs #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
reviewed
Apr 27, 2022
There was a problem hiding this comment.
Adds instructions for devs to use custom images (e.g. for testing PRs such as api3/airnode-deployer-dev:bb9b8118940ec852c4223b13eba5a6eb97aa3b97
Is this added somewhere? I do not see it in the README, but I agree it would be nice to add as it's currently only in our private slack channel.
|
Yes at the end of both new Steps 9 and 10 there is: "If you are a developer and would like to use a different..." I've updated the example commands used there to be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api3/airnode-deployer-dev:bb9b8118940ec852c4223b13eba5a6eb97aa3b97@kolenic-martin )