Remove airnode address from template verification #1037
Conversation
| @@ -8,7 +8,6 @@ interface ValidatedField { | |||
|
|
|||
| function getTemplateIdValidationFields(template: ApiCallTemplateWithoutId): ValidatedField[] { | |||
| return [ | |||
| { type: 'address', value: template.airnodeAddress }, | |||
There was a problem hiding this comment.
I think @acenolaza is correct. The getExpectedTemplateId function is used in api/index.ts (https://github.com/api3dao/airnode/blob/master/packages/airnode-node/src/api/index.ts#L149) both for signed data gateway requests but also regular Airnode RRP requests. That's why you had to change tests everywhere, not just the ones for callApi. I think this change breaks the Airnode RRP. We need two different template ID derivation functions, one for Airnode RRP (v0 contracts) and one for signed data gateway (v1 contracts).
There was a problem hiding this comment.
Do you prefer to have two separate functions, or we could pass the request type (regular/http-signed-gateway) into getExpectedTemplateId and return based on that?
There was a problem hiding this comment.
I think two separate functions will result in a nicer code.
This removes airnode address as an input for templateId derivation.