Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add php 7.3 to travis #2290

Closed
wants to merge 2 commits into from
Closed

add php 7.3 to travis #2290

wants to merge 2 commits into from

Conversation

andreybolonin
Copy link

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@antograssiot
Copy link
Contributor

This will need doctrine/orm#7325 to be released

@antograssiot
Copy link
Contributor

https://github.com/doctrine/doctrine2/releases/tag/v2.6.3
Just restarted the Travis build

@teohhanhui
Copy link
Contributor

SymfonyInsight failure is a false positive (YAML parsing error).

@teohhanhui
Copy link
Contributor

Needs a rebase.

@antograssiot
Copy link
Contributor

@andreybolonin would you mind rebasing and targeting 2.3 ?

@dunglas dunglas mentioned this pull request Dec 20, 2018
Merged
@dunglas
Copy link
Member

dunglas commented Dec 20, 2018

Thanks @andreybolonin, your commit has been included in #2403

@dunglas dunglas closed this Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhelias maxhelias maxhelias approved these changes

@antograssiot antograssiot antograssiot approved these changes

@teohhanhui teohhanhui teohhanhui approved these changes

@dunglas dunglas dunglas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andreybolonin @antograssiot @teohhanhui @dunglas @maxhelias