Range area fixes for curve types: straight, stepline, linestep, smooth #4369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
rosco54
force-pushed
the
RangeArea_update_straight_lines
branch
3 times, most recently
from
b6c4bdd
to
7af6f60
Compare
Together with previously merged changes includes curve types: straight, stepline, linestep, smooth Refactored the curve-specific branches in Line.createPaths() Fix typo 'monotonCubic' Clamp marker sizes to >= zero to avoid console errors. (Only occurred with markers on series with null datapoints.) Aesthetic update to e2e sample.
rosco54
force-pushed
the
RangeArea_update_straight_lines
branch
from
7af6f60
to
453a911
Compare
junedchhipa
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RangeArea fixes for data series with nulls
Together with previously merged changes includes curve types:
straight, stepline, linestep, smooth
Unchanged from previous:
Does not fix the animation glitches due to pathsFrom/pathsTo not handling nulls.
Issues addressed
Fixes #3525
Fixes #3821
Type of change
All the usual tests have passed with these changes, including samples from the bug reports plus my own variants designed to be slightly more stressful for the code.