Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate set-cookie headers #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jpillora
Copy link

Currently, this will result in 2 set-cookie headers. One in Headers and one in Cookies.

	http.SetCookie(w, &http.Cookie{
		Name:  "foo",
		Value: "bar",
	})

Without this fix, the included test fails on assert.Equal(t, 1, len(e.Headers)) (has 2, Content-Type + Set-Cookie)

Also @wolfeidau @tj the tests are passing, though like in #39, I'm guessing this will fail with AWS Build/Semaphore - are these build processes broken? Maybe we can just disable them and just use Actions to run the tests.

@jpillora jpillora changed the title Fix duplicate set-cookie headerss Fix duplicate set-cookie headers May 19, 2021
@wolfeidau
Copy link
Contributor

@jpillora yeah i would love to sort this out but I got removed from the org recently 😞 cc @tj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants