Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raname Custom Labels File #358

Conversation

wimvelzeboer
Copy link
Contributor

@wimvelzeboer wimvelzeboer commented Aug 23, 2021

There seems to be installation problems when the filename is not matching "CustomLabels.labels-meta.xml".

Resolves issue #357


This change is Reviewable

There seems to be installation problems when the file is not matching "CustomLabels.labels-meta.xml"
@wimvelzeboer wimvelzeboer mentioned this pull request Aug 23, 2021
@ImJohnMDaniel
Copy link
Contributor

@wimvelzeboer What issues are you seeing and what has changed that would bring these issues about now?

@daveespo
Copy link
Contributor

@wimvelzeboer -- I'm not facing a problem doing a sfdx force:source:push with this repo prior to your changes.

I see this and it looks like it's been merged and I would expect it to be in next week's CLI build:

forcedotcom/source-deploy-retrieve#427

@wimvelzeboer
Copy link
Contributor Author

@ImJohnMDaniel @daveespo Indeed, it seems to be an issue in the SFDX CLI for the force:source:deploy command.
So, we can either wait until they fix it or rename the CustomLabels file.

@ImJohnMDaniel
Copy link
Contributor

@wimvelzeboer -- let's wait for the CLI fix. The custom labels file was deliberately created like this for the use case when developers include this repo into their own larger code repo. Having the custom labels file uniquely named avoids a collision of multiple "CustomLabels" files.

Unless there is no objections, I would like to cancel this PR.

@daveespo
Copy link
Contributor

I'm in agreement; this week's CLI release will have a fix for the Custom Labels regression:

https://github.com/forcedotcom/cli/tree/main/releasenotes#aug-26-2021

@daveespo daveespo closed this Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants