Domain Process Coordinator - Execute Action Asynchronously when true #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ImJohnMDaniel,
Hope you're well! Might I propose this change? I recently ran into a use case when the
DomainProcessAbstractAction
that ships with the framework did not meet my requirements. The scope of my use case, however, was limited to the methods provided byIDomainProcessAction
(I did not need to implementIDomainProcessQueueableAction
).So, in my action class, instead of extending
DomainProcessAbstractAction
, I just implementedIDomainProcessAction
. When I did this, I ran into this issue with theDomainProcessCoordinator
. Because the coordinator is checking whethercurrentDomainProcess.ExecuteAsynchronous__c != null
(it will never be null since it is a boolean field), by proxy we must always implementIDomainProcessQueueableAction
. If we switch theif
to just check for ifExecuteAsynchronous__c = true
, then we do not have to implementIDomainProcessQueueableAction
.Curious to know your thoughts on this,
Ryan
This change is