-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poc - Alert logging for performance Degradation #17
base: main
Are you sure you want to change the base?
Poc - Alert logging for performance Degradation #17
Conversation
… if user don't want, and some code refactoring
}, | ||
{ | ||
"start_range" : 8001, | ||
"end_range" : 10000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some limits like CPU can overflow in SF and so a value of say 10050 would be possible. Would that still be caught for an alert here or would it be missed? Should the highest value not be a range and just have a start value for anything > than this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes for the highest value we can skip the end range
{ | ||
"start_range" : 0, | ||
"end_range" : 50, | ||
"threshold" : 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remind me what the thresholds are for, haven't thought about this since before Christmas so just wanting to confirm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thresholds are basically the limits for which a limit can go upto.
Like we have a 7 days average of SOQL - 15
for that threshold would be - 5
So we are ok upto 15+5 = 20 SOQL queries
If the SOQL count go beyond 20 then alert will be stored
}, | ||
{ | ||
"start_range" : 45000, | ||
"end_range" : 49999, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a job had exactly 50k query rows would that still get caught?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will have to revisit the ranges again, these are just the sample ranges for the POC purpose.
Just a Poc PR, we will be decline it in future