301 improve schema type lookup performance #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwrightcertinia
approved these changes
Dec 3, 2024
pwrightcertinia
deleted the
301-improve-schema-type-lookup-performance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves loading performance on large workspaces by ~1/3rd by avoiding the need to create TypeNames just for searching for a matching Schema type declaration for the name.
It introduces a cache type that maintains a separate dictionary for Schema types so given a TypeName we can just test for a match without creating a new TypeName. The Schema dictionary is constructed as types are added to the cache.