Better completion handling on field/var declaration = n #283
Conversation
| @@ -95,6 +93,13 @@ trait CompletionProvider { | |||
| .map(keyword => CompletionItemLink(keyword, "Keyword")) | |||
| .toArray | |||
|
|
|||
| val creatorCompletions = | |||
| if (classDetails._2.nonEmpty && keywords.map(_.label).contains("new")) { | |||
| getEmptyCreatorCompletionItems(classDetails._2.get, terminatedContent._3) | |||
There was a problem hiding this comment.
the tuple accessors aren't so pretty with no IDE telling you what it is.
There was a problem hiding this comment.
Yeah, I try and write XXXAndYYY when I notice that but didn't spot this.
| val trimmed = idAssignPattern.replaceFirstIn(line, "") | ||
| if (trimmed == line) | ||
| return emptyCompletions | ||
|
|
There was a problem hiding this comment.
Does it continue to work if you half write things like new Ob ? Are we able to do that?
There was a problem hiding this comment.
Kind of, VSCode asks for completion on the 'n' and continues to show the completion if you type 'e' etc. If you type something other than 'e' it will ask for completion again if we did not provide any matches the first time around.
We have a bit of a mismatch here in that when you press 'n' we give a reply as though the 'n' wasn't there because of how we interface to C3. We could post-process that to just returning things starting with 'n' but VSCode does that for us anyway. I don't think this causes any issues but not completely sure.
kjonescertinia
deleted the
282-enhance-completion-support-of-creator-use
branch
This changes code completion handling for when the new keyword can be used. If it is preceded by
typeName identifier =and the typeName to a type with either a no arg constructor or an SObject then we replace the keyword suggestions bynew typeName();It might be possible to support other uses cases where
newis being used, such as just assigning to vars, but this matches the feature request and is probably the most common case so I have just supported on declarations.The PR has some improvements for typeName parsing as we were not handling whitespace very well.