Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update analysis provider to support config params #242

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

kjonescertinia
Copy link
Contributor

@kjonescertinia kjonescertinia commented Oct 14, 2023

This allows parameters to be provided to analysis providers. When providing we use the format Map[String, List[(String, List[String])]], the key here is for the Provider Id, we use a list for params so we do not enforce uniqueness in apex-ls. Each param being a string name and a List of string values which may be empty.

If an error occurs when setting params an info log is generated and the provider is not used. As the log may not be very visible its best for callers to make sure params are acceptable for the providers there are targeting. Before a provider is used on a workspace we check it thinks it is configured correctly and exclude those that are not.

@kjonescertinia kjonescertinia linked an issue Oct 14, 2023 that may be closed by this pull request
@kjonescertinia kjonescertinia merged commit a5dd262 into main Oct 19, 2023
1 check passed
@kjonescertinia kjonescertinia deleted the 241-update-pmd-install-process branch October 19, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update PMD install process
2 participants