226 rename provider expanded with visitor pattern #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…struct-and-provide-statement-access-on-block' into 226-rename-provider-expanded-with-visitor-pattern
|
Merging in main now should clean up the diff |
jvm/src/main/scala/com/nawforce/apexlink/org/RenameProvider.scala
Outdated
Show resolved
Hide resolved
jvm/src/main/scala/com/nawforce/apexlink/org/RenameProvider.scala
Outdated
Show resolved
Hide resolved
jvm/src/main/scala/com/nawforce/apexlink/org/RenameProvider.scala
Outdated
Show resolved
Hide resolved
…xpanded-with-visitor-pattern
pwrightcertinia
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Got a big chunk of testing here which is great and will be quite helpful.
It's best I don't pick out any more specifics as this is something where you can lose time tweaking and refactoring bits til middle of the night.
As I said, when you are ready let me know and we'll get this merged and pre-released.
pwrightcertinia
deleted the
226-rename-provider-expanded-with-visitor-pattern
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.