116 dml statements dont validate the expressions are sobjects #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-statements-dont-validate-the-expressions-are-sobjects
kjonescertinia
changed the base branch from
main
to
115-runas-statement-is-missing-validation
Base automatically changed from
115-runas-statement-is-missing-validation
to
main
September 25, 2023 16:07
…ions-are-sobjects
| (false, verifyResult) | ||
| } else { | ||
| (true, verifyResult) | ||
| } |
There was a problem hiding this comment.
There's probably a future refactor in here to split off the isDefined / static type checking as it's in every method. Just nitpicks, looks fine.
There was a problem hiding this comment.
Yeah, think we are trapped a bit here between two different design options, returning an Option[ExprContext] to allow for failure to verify and returning an Any to mask that failure. Not sure I want to try sort that just yet but we might be able to simplify some verify logic if we did.
| .contains(sObjectTypeName.name) | ||
| ) Some(sObjectTypeName) | ||
| else None | ||
| } |
There was a problem hiding this comment.
Also maybe a getSObjectTypeName() that returns an Option if it's not could be used for the isSObjectOrSObjectList method and this, there's a bit of common behaviour between these two. More nitpicky
pwrightcertinia
approved these changes
Oct 2, 2023
kjonescertinia
deleted the
116-dml-statements-dont-validate-the-expressions-are-sobjects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves validation of the DML statements insert, update, upsert, delete, undelete & merge. Most require a SObject or SObject list but merge takes two expression, the first has to be a specific SObject while the second should be a matching SObject or SObject List.
The validation are written so that if we can't get a type for the expression then we don't error. The expression(s) should have logged errors if needed.