112 missing validations on if, while & do-while #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjonescertinia
commented
Sep 20, 2023
| @@ -152,6 +152,15 @@ object LocalVariableDeclarationStatement { | |||
| final case class IfStatement(expression: Expression, statements: Seq[Statement]) extends Statement { | |||
| override def verify(context: BlockVerifyContext): Unit = { | |||
| val expr = expression.verify(context) | |||
| if (expr.isDefined && expr.typeName != TypeNames.Boolean) { | |||
There was a problem hiding this comment.
We should be checking expr.isStatic here as well, I will correct.
There was a problem hiding this comment.
Fixed this via a helper method on Statement as there are some similar cases coming for throw/catch validations.
| test("Single statement") { | ||
| // TODO: This should fail a block is required, apex-parser is over general | ||
| happyTypeDeclaration("public class Dummy {{ do System.debug(''); while (true); }}") | ||
| } |
There was a problem hiding this comment.
bomb has been planted
pwrightcertinia
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This added checking the expressions on these statements return Boolean values. For once that rule appears to be universal and there are no assignability concerns.
As part of this I have simplified the way we add Issues a little so you don't need to provide the path separately from the range. I think this previously used to be an issue due to the apexlink/pkgforce split if I am recalling correctly. Have have also included some minor IntelliJ warning fixes that got flagged due to the Issue change.
There is a bug the apex-parser on do-while in that it allows single statements but Apex only supports blocks, just to make it different from if & while. I will create a seperate tickets for correcting this.